Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: fix checksum incomplete when context is done #44583

Merged
merged 3 commits into from
Jun 16, 2023
Merged

br: fix checksum incomplete when context is done #44583

merged 3 commits into from
Jun 16, 2023

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Jun 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #44472

Problem Summary:
When BR is failed by one checksum task, the other checksum tasks' result would be incomplete.

What is changed and how it works?

check the context status before returns response.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Jun 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 12, 2023

@tonyxuqqi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 14, 2023
@Leavrth
use ctx.Err() instead
93eaff4 
Signed-off-by: Leavrth <[email protected]>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 15, 2023

/retest

5 similar comments
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 15, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 15, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 16, 2023
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, tonyxuqqi, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-14 10:18:49.565838659 +0000 UTC m=+167325.980442723: ☑️ agreed by YuJuncen.
  • 2023-06-15 02:38:13.489649908 +0000 UTC m=+226089.904253979: ☑️ agreed by 3pointer.
  • 2023-06-16 06:34:41.293026146 +0000 UTC m=+326677.707630224: ✖️🔁 reset by Leavrth.
  • 2023-06-16 07:14:11.694970113 +0000 UTC m=+329048.109574178: ☑️ agreed by YuJuncen.
  • 2023-06-16 07:24:04.219663852 +0000 UTC m=+329640.634267932: ☑️ agreed by 3pointer.

@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

1 similar comment
@Leavrth
Copy link
Contributor Author

Leavrth commented Jun 16, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit 052c17f into pingcap:master Jun 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 16, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #44735.

ti-chi-bot bot pushed a commit that referenced this pull request Jun 20, 2023
@ti-chi-bot
br: fix checksum incomplete when context is done (#44583) (#44735)
62e13fa 
close #44472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

@tonyxuqqi tonyxuqqi tonyxuqqi approved these changes

@3pointer 3pointer 3pointer approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: when full restore to multi rocksdb cluster, checksum will be mismatch sometimes
5 participants
@Leavrth @ti-chi-bot @3pointer @tonyxuqqi @YuJuncen